[webkit-reviews] review granted: [Bug 231728] Remove std::iterator usage : [Attachment 441196] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 14 06:26:40 PDT 2021
Keith Miller <keith_miller at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 231728: Remove std::iterator usage
https://bugs.webkit.org/show_bug.cgi?id=231728
Attachment 441196: Patch
https://bugs.webkit.org/attachment.cgi?id=441196&action=review
--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 441196
--> https://bugs.webkit.org/attachment.cgi?id=441196
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=441196&action=review
> Source/WebCore/platform/Timer.cpp:336
> + std::push_heap(TimerHeapIterator(heapData), TimerHeapIterator(heapData +
m_heapItem->heapIndex() + 1), TimerHeapLessThanFunction());
What's the deal here? I don't see where we're `using std::push_heap` anywhere.
Is that in a different file?
More information about the webkit-reviews
mailing list