[webkit-reviews] review granted: [Bug 231663] All the SDKVariant.xcconfig files should match : [Attachment 441176] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 13 23:16:23 PDT 2021
youenn fablet <youennf at gmail.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 231663: All the SDKVariant.xcconfig files should match
https://bugs.webkit.org/show_bug.cgi?id=231663
Attachment 441176: Patch
https://bugs.webkit.org/attachment.cgi?id=441176&action=review
--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 441176
--> https://bugs.webkit.org/attachment.cgi?id=441176
Patch
LGTM
View in context: https://bugs.webkit.org/attachment.cgi?id=441176&action=review
> Source/JavaScriptCore/ChangeLog:8
> + The linter says they're all supposed to match.
I do not see the style checker being red in the patch the changes were added
(https://bugs.webkit.org/show_bug.cgi?id=225505).
Was the style checker updated after the changes were done?
More information about the webkit-reviews
mailing list