[webkit-reviews] review granted: [Bug 231606] ASSERT hit in surrogatePairAwareIndex and surrogatePairAwareStart lambdas for text with unpaired surrogates : [Attachment 441156] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 231606: ASSERT hit in surrogatePairAwareIndex and surrogatePairAwareStart
lambdas for text with unpaired surrogates
https://bugs.webkit.org/show_bug.cgi?id=231606

Attachment 441156: Patch

https://bugs.webkit.org/attachment.cgi?id=441156&action=review




--- Comment #23 from Darin Adler <darin at apple.com> ---
Comment on attachment 441156
  --> https://bugs.webkit.org/attachment.cgi?id=441156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441156&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:151
> +	   RELEASE_ASSERT(offset - 1 < text.length());

Not 100% sure we need this RELEASE_ASSERT.