[webkit-reviews] review denied: [Bug 227537] Implement <dialog> focusing steps : [Attachment 441113] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied  review:
Bug 227537: Implement <dialog> focusing steps
https://bugs.webkit.org/show_bug.cgi?id=227537

Attachment 441113: Patch

https://bugs.webkit.org/attachment.cgi?id=441113&action=review




--- Comment #26 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 441113
  --> https://bugs.webkit.org/attachment.cgi?id=441113
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441113&action=review

> Source/WebCore/html/HTMLDialogElement.cpp:53
>      setBooleanAttribute(openAttr, true);

This can affect style...

> Source/WebCore/html/HTMLDialogElement.cpp:57
> +    runFocusingSteps();

So we have to update style and layout before running these steps.

> Source/WebCore/html/HTMLDialogElement.cpp:75
>	   addToTopLayer();

This can affect style...

> Source/WebCore/html/HTMLDialogElement.cpp:79
> +    runFocusingSteps();

So we have to update style and layout before running these steps.