[webkit-reviews] review granted: [Bug 231679] Drop makeWeakPtr() and use WeakPtr { } directly : [Attachment 441128] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 231679: Drop makeWeakPtr() and use WeakPtr { } directly
https://bugs.webkit.org/show_bug.cgi?id=231679

Attachment 441128: Patch

https://bugs.webkit.org/attachment.cgi?id=441128&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 441128
  --> https://bugs.webkit.org/attachment.cgi?id=441128
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441128&action=review

> Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:233
> +   
gpuProcess.audioSessionManager().session().setRoutingArbitrationClient(WeakPtr
{ m_routingArbitrator.get() });

Can we leave out the explicit conversion to WeakPtr? I saw many other cases
where it seems we were able to do that.

> Source/WebKit/GPUProcess/media/RemoteCDMInstanceProxy.cpp:56
> +    m_instance->setClient(static_cast<CDMInstanceClient&>(*this));

Why is the static_cast needed? What compilation failure do we get without the
cast?