[webkit-reviews] review granted: [Bug 231410] Scroll To Text Fragment directive parsing : [Attachment 441141] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 13 15:10:40 PDT 2021

Chris Dumez <cdumez at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 231410: Scroll To Text Fragment directive parsing

Attachment 441141: Patch


--- Comment #27 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 441141
  --> https://bugs.webkit.org/attachment.cgi?id=441141

View in context: https://bugs.webkit.org/attachment.cgi?id=441141&action=review

> Source/WebCore/dom/Document.h:1635
> +    void setFragmentDirective(String& fragmentDirective) {
m_fragmentDirective = fragmentDirective; }

const String&

> Source/WebCore/dom/FragmentDirectiveParser.cpp:92
> +		   continue;

What's the point of this continue statement? Seems like a no-op.

Maybe we could do this logging in the `for (auto token :
textDirective.split(','))` loop above to avoid iterating over the tokens again?

More information about the webkit-reviews mailing list