[webkit-reviews] review granted: [Bug 231626] Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw commands : [Attachment 440990] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 15:46:26 PDT 2021


Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 231626: Upstream ANGLE: PrimitiveRestart tests fail due to incorrect draw
commands
https://bugs.webkit.org/show_bug.cgi?id=231626

Attachment 440990: Patch

https://bugs.webkit.org/attachment.cgi?id=440990&action=review




--- Comment #3 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 440990
  --> https://bugs.webkit.org/attachment.cgi?id=440990
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440990&action=review

Looks good - one comment. r+

> Source/ThirdParty/ANGLE/ChangeLog:10
> +	   index buffer was aliased / reused.

Please mention "Cherry-pick from upstream anglebug.com/6535" or similar to keep
the association clear.


More information about the webkit-reviews mailing list