[webkit-reviews] review granted: [Bug 231464] [macOS] Add support for accent-color : [Attachment 440748] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 14:07:38 PDT 2021

Tim Horton <thorton at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 231464: [macOS] Add support for accent-color

Attachment 440748: Patch


--- Comment #6 from Tim Horton <thorton at apple.com> ---
Comment on attachment 440748
  --> https://bugs.webkit.org/attachment.cgi?id=440748

View in context: https://bugs.webkit.org/attachment.cgi?id=440748&action=review

> Source/WebCore/platform/Theme.cpp:73
> +void Theme::paint(ControlPart, ControlStates&, GraphicsContext&, const
FloatRect&, float, ScrollView*, float, float, bool, bool, const Color&)

At what point do we package this up in a struct or something?

> Source/WebCore/rendering/style/RenderStyle.cpp:2182
> +    if (!hasAppleColorFilter())
> +	   return colorResolvingCurrentColor(accentColor());

Kinda would expect the weird case (color-filter) to be the early return (but
this is fine too).

> LayoutTests/platform/mac/TestExpectations:2350
> +webkit.org/b/199350 fast/css/accent-color/datalist.html [ ImageOnlyFailure ]

Maybe these two failing ones go in their own paragraph that doesn't have a
header suggesting these are passing because they're supported?

More information about the webkit-reviews mailing list