[webkit-reviews] review granted: [Bug 231560] Implement alternate style for textarea : [Attachment 440899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 11:18:31 PDT 2021


Devin Rousso <drousso at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 231560: Implement alternate style for textarea
https://bugs.webkit.org/show_bug.cgi?id=231560

Attachment 440899: Patch

https://bugs.webkit.org/attachment.cgi?id=440899&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 440899
  --> https://bugs.webkit.org/attachment.cgi?id=440899
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440899&action=review

r=me

> Source/WebCore/rendering/RenderThemeIOS.mm:607
> +	   if (is<HTMLTextAreaElement>(*element))

NIT: Should this be an `else if` so we don't check it if we enter the `if
(is<HTMLInputElement>(*element))` above?

> Source/WebCore/rendering/RenderThemeIOS.mm:641
> +    bool useAlternateDesign =
element->document().settings().alternateFormControlDesignEnabled();

NIT: Does this need to be a separate variable?


More information about the webkit-reviews mailing list