[webkit-reviews] review granted: [Bug 231593] Scrolling thread animations need to commit layers on the scrolling thread : [Attachment 440955] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 231593: Scrolling thread animations need to commit layers on the scrolling
thread
https://bugs.webkit.org/show_bug.cgi?id=231593

Attachment 440955: Patch

https://bugs.webkit.org/attachment.cgi?id=440955&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 440955
  --> https://bugs.webkit.org/attachment.cgi?id=440955
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440955&action=review

> Source/WebKit/ChangeLog:8
> +	   Scroll animations were running the scrolling thread (in that the
timers were firing on that

"on"

> Source/WebKit/ChangeLog:9
> +	   thread), but the scrolling thread wasn't changing layer positons, so
those animations

positons!

> Source/WebKit/ChangeLog:26
> +	   Scroll animations are still based on a 60Hz timer, but in future
should be driven by
> +	   displayDidRefresh() notifications.

Excitement!