[webkit-reviews] review granted: [Bug 231582] Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_alternative : [Attachment 440942] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 231582: Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and
WTF::holds_alternative
https://bugs.webkit.org/show_bug.cgi?id=231582

Attachment 440942: Patch

https://bugs.webkit.org/attachment.cgi?id=440942&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 440942
  --> https://bugs.webkit.org/attachment.cgi?id=440942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440942&action=review

r=me assuming compile succeeds (which I assume it will since this was done with
global replace, I hope)

> Source/JavaScriptCore/ChangeLog:3
> +	   Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and
WTF::holds_alternative

Pedantic terminology nitpick: The term "STL" is a bit archaic and I don’t think
it applies here; you just mean the C++ standard library.