[webkit-reviews] review granted: [Bug 231401] WebKitTestRunner should check mainFrameURL exists in InjectedBundlePage::willSendRequestForFrame : [Attachment 440672] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 12 00:46:51 PDT 2021


youenn fablet <youennf at gmail.com> has granted Gabriel Nava Marino
<gnavamarino at apple.com>'s request for review:
Bug 231401: WebKitTestRunner should check mainFrameURL exists in
InjectedBundlePage::willSendRequestForFrame
https://bugs.webkit.org/show_bug.cgi?id=231401

Attachment 440672: Patch

https://bugs.webkit.org/attachment.cgi?id=440672&action=review




--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 440672
  --> https://bugs.webkit.org/attachment.cgi?id=440672
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440672&action=review

> Tools/ChangeLog:9
> +	   (WTR::InjectedBundlePage::willSendRequestForFrame):

Let's add a comment explaining the case for this check:
Add mainFrameURL check in case of loading a non localhost URL with
WebKitTestRunner.


More information about the webkit-reviews mailing list