[webkit-reviews] review granted: [Bug 231490] https://tankionline.com/play/ html5 engine not working: crashes. (Metal shader not working) : [Attachment 440847] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 11 15:24:02 PDT 2021
Kenneth Russell <kbr at google.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 231490: https://tankionline.com/play/ html5 engine not working: crashes.
(Metal shader not working)
https://bugs.webkit.org/show_bug.cgi?id=231490
Attachment 440847: Patch
https://bugs.webkit.org/attachment.cgi?id=440847&action=review
--- Comment #4 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 440847
--> https://bugs.webkit.org/attachment.cgi?id=440847
Patch
Looks good to me assuming all tests pass. Would you be able to put up the new
test as a pull request against the WebGL conformance suite? r+
More information about the webkit-reviews
mailing list