[webkit-reviews] review denied: [Bug 227537] Implement <dialog> focusing steps : [Attachment 440840] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 11 15:01:27 PDT 2021


Chris Dumez <cdumez at apple.com> has denied Tim Nguyen (:ntim) <ntim at apple.com>'s
request for review:
Bug 227537: Implement <dialog> focusing steps
https://bugs.webkit.org/show_bug.cgi?id=227537

Attachment 440840: Patch

https://bugs.webkit.org/attachment.cgi?id=440840&action=review




--- Comment #12 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 440840
  --> https://bugs.webkit.org/attachment.cgi?id=440840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440840&action=review

>> Source/WebCore/html/HTMLDialogElement.cpp:149
>> +	topDocument->autofocusCandidates().clear();
> 
> This is currently a no-op.

You likely want to add a clearAutofocusCandidates() to Document.


More information about the webkit-reviews mailing list