[webkit-reviews] review granted: [Bug 231407] [GPU Process] Unique RenderingResourceIdentifiers Part 5: Migrate RemoteResourceCache to QualifiedRenderingResourceIdentifier : [Attachment 440567] Patch

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 231407: [GPU Process] Unique RenderingResourceIdentifiers Part 5: Migrate
RemoteResourceCache to QualifiedRenderingResourceIdentifier
https://bugs.webkit.org/show_bug.cgi?id=231407

Attachment 440567: Patch

https://bugs.webkit.org/attachment.cgi?id=440567&action=review




--- Comment #3 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 440567
  --> https://bugs.webkit.org/attachment.cgi?id=440567
Patch

This patch looks okay. But I am surprised that RemoteImageBuffer currently has
two identifiers. One is from the base class:
ConcreteImageBuffer::m_renderingResourceIdentifier and the other is
RemoteImageBuffer::m_renderingResourceIdentifier. The later was added in
r269682. Luckily they hold the same value. But I think this needs to be
cleaned-up.