[webkit-reviews] review granted: [Bug 231491] Implement parsing support for offset-distance, offset-position, offset-anchor : [Attachment 440736] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kiet Ho
<tho22 at apple.com>'s request for review:
Bug 231491: Implement parsing support for offset-distance, offset-position,
offset-anchor
https://bugs.webkit.org/show_bug.cgi?id=231491

Attachment 440736: Patch

https://bugs.webkit.org/attachment.cgi?id=440736&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 440736
  --> https://bugs.webkit.org/attachment.cgi?id=440736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440736&action=review

Looks like you need to rebase more tests.

> Source/WebCore/ChangeLog:8
> +	   No new tests; WPT parsing tests are sufficient.

If bits of this patch are from external contributors, you should acknowledge
them here.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3180
> +	   case CSSPropertyObjectPosition:
> +	       return valueForPosition(style, style.objectPosition());
> +	   case CSSPropertyOffsetDistance:
> +	       return cssValuePool.createValue(style.offsetDistance(), style);
> +	   case CSSPropertyOffsetPosition:
> +	       return valueForPositionOrAuto(style, style.offsetPosition());
> +	   case CSSPropertyOffsetAnchor:
> +	       return valueForPositionOrAuto(style, style.offsetAnchor());

You can also use your helper for CSSPropertyPerspectiveOrigin, maybe others.