[webkit-reviews] review granted: [Bug 231512] [run-benchmark] Make Python 3 compatible : [Attachment 440792] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 231512: [run-benchmark] Make Python 3 compatible
https://bugs.webkit.org/show_bug.cgi?id=231512

Attachment 440792: Patch

https://bugs.webkit.org/attachment.cgi?id=440792&action=review




--- Comment #3 from dewei_zhu at apple.com ---
Comment on attachment 440792
  --> https://bugs.webkit.org/attachment.cgi?id=440792
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440792&action=review

r=me

>
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
107
> +	   )

If we decide to go with invoking decode('utf-8') on output, we may not need it
here because I don't think use output from `_browser_process` anyway.

>
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:73
> +		   **(dict(encoding='utf-8') if sys.version_info >= (3, 0) else
dict())

I think encoding only available since python3.6.
A most compatible way would be `process.communicate()[0].decode('utf-8')`.