[webkit-reviews] review granted: [Bug 231484] Introduce RemoteDisplayListRecorderProxy and RemoteDisplayListRecorder : [Attachment 440746] Fix typo

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 231484: Introduce RemoteDisplayListRecorderProxy and
RemoteDisplayListRecorder
https://bugs.webkit.org/show_bug.cgi?id=231484

Attachment 440746: Fix typo

https://bugs.webkit.org/attachment.cgi?id=440746&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 440746
  --> https://bugs.webkit.org/attachment.cgi?id=440746
Fix typo

View in context: https://bugs.webkit.org/attachment.cgi?id=440746&action=review

> Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:46
> +    static Ref<RemoteDisplayListRecorder> create(WebCore::ImageBuffer&
imageBuffer, QualifiedRenderingResourceIdentifier imageBufferIdentifier,
RemoteRenderingBackend& renderingBackend)

Can this ImageBuffer type be template-qualified so that we know at compile time
that it's the right kind of image buffer?

> Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h:52
> +    void startListeningForIPC();
> +    void stopListeningForIPC();

These feel a bit weird on this API.

> Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:42
> +    RemoteDisplayListRecorderProxy(WebCore::ImageBuffer&,
RemoteRenderingBackendProxy&, const WebCore::FloatRect& initialClip, const
WebCore::AffineTransform&, WebCore::DrawGlyphsRecorder::DeconstructDrawGlyphs =
WebCore::DrawGlyphsRecorder::DeconstructDrawGlyphs::Yes);

Same question: can ImageBuffer be specialized? It's a concrete image buffer
here, right?

> Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.h:45
> +    ~RemoteDisplayListRecorderProxy() { }

= default?