[webkit-reviews] review granted: [Bug 231362] [JSC][32bit] Fix wrong branchAdd32 assembly for ARMv7 : [Attachment 440530] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 231362: [JSC][32bit] Fix wrong branchAdd32 assembly for ARMv7
https://bugs.webkit.org/show_bug.cgi?id=231362

Attachment 440530: Patch

https://bugs.webkit.org/attachment.cgi?id=440530&action=review




--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 440530
  --> https://bugs.webkit.org/attachment.cgi?id=440530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440530&action=review

r=me with changes.

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:200
> +    void add32(TrustedImm32 imm, Address address, bool updateFlags = false)

Let's define it as add32Impl helper private function, and define add32 as

void add32(TrustedImm32 imm, Address address)
{
    constexpr bool updateFlags = false;
    add32Impl(imm, address, updateFlags);
}

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:229
> +    void add32(TrustedImm32 imm, AbsoluteAddress address, bool updateFlags =
false)

Let's define it as add32Impl helper private function, and define add32 as

void add32(TrustedImm32 imm, AbsoluteAddress address)
{
    constexpr bool updateFlags = false;
    add32Impl(imm, address, updateFlags);
}

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1861
> +	   add32(imm, dest, true);

Let's make it readable by,

constexpr bool updateFlags = true;
add32(imm, dest, updateFlags);

> Source/JavaScriptCore/assembler/MacroAssemblerARMv7.h:1867
> +	   add32(imm, dest, true);

Let's make it readable by,

constexpr bool updateFlags = true;
add32(imm, dest, updateFlags);