[webkit-reviews] review granted: [Bug 231505] Error the encoder in case we cannot create a RemoteVideoSample : [Attachment 440767] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 231505: Error the encoder in case we cannot create a RemoteVideoSample
https://bugs.webkit.org/show_bug.cgi?id=231505

Attachment 440767: Patch

https://bugs.webkit.org/attachment.cgi?id=440767&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 440767
  --> https://bugs.webkit.org/attachment.cgi?id=440767
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440767&action=review

> Source/WebKit/WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:451
> +	   if (!sample)
> +	       return WEBRTC_VIDEO_CODEC_ERROR;

It might be worth logging this error too.