[webkit-reviews] review granted: [Bug 231443] [css-ui] Fix interpolation of accent-color : [Attachment 440652] Patch

[bugzilla-daemon at webkit.org]

Antoine Quint <graouts at webkit.org> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 231443: [css-ui] Fix interpolation of accent-color
https://bugs.webkit.org/show_bug.cgi?id=231443

Attachment 440652: Patch

https://bugs.webkit.org/attachment.cgi?id=440652&action=review




--- Comment #4 from Antoine Quint <graouts at webkit.org> ---
Comment on attachment 440652
  --> https://bugs.webkit.org/attachment.cgi?id=440652
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440652&action=review

Very nice! Thanks for catching this and fixing it Aditya.

>> Source/WebCore/animation/CSSPropertyAnimation.cpp:1490
>> +	    auto& blendingRenderStyle = context.progress < 0.5 ? from : to;
> 
> If canInterpolate(from, to) is false, then progress should have already been
set to either 0 or 1 in CSSPropertyAnimation::blendProperties(). I think you
should ASSERT() that you're only dealing with 0 or 1 here and change this line
to `auto& blendingRenderStyle = context.progress ? from : to;`.

If canInterpolate(from, to) is false, then progress should have already been
set to either 0 or 1 in CSSPropertyAnimation::blendProperties(). I think you
should ASSERT() that you're only dealing with 0 or 1 here and change this line
to `auto& blendingRenderStyle = context.progress ? from : to;`.