[webkit-reviews] review denied: [Bug 231417] Refactor shouldAutofocus to only call trivial Document getters : [Attachment 440590] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 9 01:23:18 PDT 2021
Ryosuke Niwa <rniwa at webkit.org> has denied review:
Bug 231417: Refactor shouldAutofocus to only call trivial Document getters
https://bugs.webkit.org/show_bug.cgi?id=231417
Attachment 440590: Patch
https://bugs.webkit.org/attachment.cgi?id=440590&action=review
--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 440590
--> https://bugs.webkit.org/attachment.cgi?id=440590
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=440590&action=review
> Source/WebCore/html/HTMLFormControlElement.cpp:210
> auto& document = element.document();
We really need to store this in Ref. r- because of this.
More information about the webkit-reviews
mailing list