[webkit-reviews] review granted: [Bug 231203] Add support for '-webkit-appearance: auto' : [Attachment 440522] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 8 14:24:54 PDT 2021
Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 231203: Add support for '-webkit-appearance: auto'
https://bugs.webkit.org/show_bug.cgi?id=231203
Attachment 440522: Patch
https://bugs.webkit.org/attachment.cgi?id=440522&action=review
--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 440522
--> https://bugs.webkit.org/attachment.cgi?id=440522
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=440522&action=review
> Source/WebCore/rendering/RenderTheme.cpp:294
> + auto& element = *elementPtr;
Nit - I think current guidelines
(https://lists.webkit.org/pipermail/webkit-dev/2020-September/031386.html)
recommend storing this as a `Ref` instead of a raw reference.
> Source/WebCore/rendering/RenderTheme.cpp:300
> + return PushButtonPart;
Just as an aside — we should consider making these strongly typed `enum class`
at some point.
More information about the webkit-reviews
mailing list