[webkit-reviews] review granted: [Bug 231441] Ensure that animated scrolls will run on the scrolling thread : [Attachment 440660] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 14:00:58 PDT 2021


Tim Horton <thorton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 231441: Ensure that animated scrolls will run on the scrolling thread
https://bugs.webkit.org/show_bug.cgi?id=231441

Attachment 440660: Patch

https://bugs.webkit.org/attachment.cgi?id=440660&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 440660
  --> https://bugs.webkit.org/attachment.cgi?id=440660
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440660&action=review

> Source/WebCore/ChangeLog:8
> +	   On macOS, scrolling tree commits run the main thread (holding a
lock), so we can't start

missing an "on" I think

> Source/WebCore/ChangeLog:12
> +	   to bounce to the scrolling tree to start animations. We also have
intercept requested scroll

"we have intercept"


More information about the webkit-reviews mailing list