[webkit-reviews] review granted: [Bug 229681] Implement the WebAssembly exception handling proposal : [Attachment 440463] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 229681: Implement the WebAssembly exception handling proposal
https://bugs.webkit.org/show_bug.cgi?id=229681

Attachment 440463: Patch

https://bugs.webkit.org/attachment.cgi?id=440463&action=review




--- Comment #17 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 440463
  --> https://bugs.webkit.org/attachment.cgi?id=440463
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440463&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:94
> +    unsigned m_callSiteIndex {s_invalidCallSiteIndex };

Style: add space after {

> Source/JavaScriptCore/wasm/WasmTag.cpp:36
> +}} // namespace JSC::Wasm

Style add space between }s

> Source/JavaScriptCore/wasm/WasmTag.h:55
> +    static uint32_t s_id;

This needs to be atomic.

> Source/JavaScriptCore/wasm/generateWasmB3IRGeneratorInlinesHeader.py:197
> -""" + generateB3Code(opcode, b3op) + """;
> +""" + generateB3Code(opcode, b3op) + """

Why make this change?

> Source/JavaScriptCore/wasm/wasm.json:45
> +	   "Exception": { "type": "varuint7", "value": 13, "description":
"Exception declarations" }

I think we should keep this consistent with the one in JSTests. I moved this
line up so the builder had the proper expected section ordering.