[webkit-reviews] review granted: [Bug 231138] REGRESSION (r277818): XHR with requestType document broken for larger HTML files : [Attachment 440597] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 8 08:17:29 PDT 2021


Darin Adler <darin at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 231138: REGRESSION (r277818): XHR with requestType document broken for
larger HTML files
https://bugs.webkit.org/show_bug.cgi?id=231138

Attachment 440597: Patch

https://bugs.webkit.org/attachment.cgi?id=440597&action=review




--- Comment #20 from Darin Adler <darin at apple.com> ---
Comment on attachment 440597
  --> https://bugs.webkit.org/attachment.cgi?id=440597
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440597&action=review

> Source/WebCore/dom/DocumentParser.h:54
> +    virtual void appendSynchronously(RefPtr<StringImpl>&& inputSource) {
append(WTFMove(inputSource)); }

Totally not about this patch: I do not think we should ever use the type
RefPtr<StringImpl> since that’s exactly how String is implemented. I could
understand StringImpl* or Ref<StringImpl>, but RefPtr<StringImpl> in particular
is just an alternate way to say String, and I think it’s annoying that we mix
the two.


More information about the webkit-reviews mailing list