[webkit-reviews] review granted: [Bug 222860] [WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden : [Attachment 440603] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 222860: [WPE] Reenable -fvisibility=hidden and -fvisibility-inlines-hidden
https://bugs.webkit.org/show_bug.cgi?id=222860

Attachment 440603: Patch

https://bugs.webkit.org/attachment.cgi?id=440603&action=review




--- Comment #11 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 440603
  --> https://bugs.webkit.org/attachment.cgi?id=440603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440603&action=review

> Source/cmake/OptionsWPE.cmake:151
> +set(CMAKE_C_VISIBILITY_PRESET hidden)
> +set(CMAKE_CXX_VISIBILITY_PRESET hidden)
> +set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)

Let's land this in two steps:

 (1) Everything except this portion of the diff, r=me
 (2) This part, in a second commit.

That way, we don't have to revert (1) if it turns out there is some problem
caused by (2).