[webkit-reviews] review canceled: [Bug 231338] [Cocoa] Web Inspector: provide a way for _WKInspectorExtension clients to be notified when the inspected page navigates : [Attachment 440528] Patch v1.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 16:41:30 PDT 2021


BJ Burg <bburg at apple.com> has canceled BJ Burg <bburg at apple.com>'s request for
review:
Bug 231338: [Cocoa] Web Inspector: provide a way for _WKInspectorExtension
clients to be notified when the inspected page navigates
https://bugs.webkit.org/show_bug.cgi?id=231338

Attachment 440528: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=440528&action=review




--- Comment #5 from BJ Burg <bburg at apple.com> ---
Comment on attachment 440528
  --> https://bugs.webkit.org/attachment.cgi?id=440528
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=440528&action=review

>>
Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController
.js:278
>> +	   
InspectorFrontendHost.inspectedPageDidNavigate(WI.networkManager.mainFrame.url)
;
> 
> Thinking about this a bit more, it seems like more work to add/remove the
event listener based on the presence of the extension.	Instead, why don't we
just always listen and only call
`InspectorFrontendHost.inspectedPageDidNavigate` if we know we have some (e.g.
`this._extensionForExtensionIDMap.size`)?

OK


More information about the webkit-reviews mailing list