[webkit-reviews] review granted: [Bug 231281] [GPU Process] Unique RenderingResourceIdentifiers Part 1: Uniquify at entry points : [Attachment 440547] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 231281: [GPU Process] Unique RenderingResourceIdentifiers Part 1: Uniquify
at entry points
https://bugs.webkit.org/show_bug.cgi?id=231281

Attachment 440547: Patch

https://bugs.webkit.org/attachment.cgi?id=440547&action=review




--- Comment #18 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 440547
  --> https://bugs.webkit.org/attachment.cgi?id=440547
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440547&action=review

r=me. It may have been nice to use ProcessQualifiedIdentifier and use an
ObjectIdentifier<T>. I am not sure how useful this could be for other types.

> Source/WebCore/platform/ProcessQualified.h:107
> +}

Would be nice to add this here as we usually do.
 // namespace WebCore

> Source/WebCore/platform/ProcessQualified.h:130
> +}

Would be nice to add this here as we usually do.
 // namespace WTF