[webkit-reviews] review granted: [Bug 231385] BifurcatedGraphicsContext doesn't bifurcate draw{Tiled}Image : [Attachment 440531] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 13:43:37 PDT 2021


Devin Rousso <drousso at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 231385: BifurcatedGraphicsContext doesn't bifurcate draw{Tiled}Image
https://bugs.webkit.org/show_bug.cgi?id=231385

Attachment 440531: Patch

https://bugs.webkit.org/attachment.cgi?id=440531&action=review




--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 440531
  --> https://bugs.webkit.org/attachment.cgi?id=440531
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440531&action=review

r=me

> Source/WebCore/platform/graphics/BifurcatedGraphicsContext.h:102
> +    ImageDrawResult drawImage(Image&, const FloatRect& destination, const
FloatRect& source, const ImagePaintingOptions& = { ImageOrientation::FromImage
}) final;

Aside: it's kinda odd that the other `drawImage` are also `virtual` even though
they just call into one of the other `drawImage`


More information about the webkit-reviews mailing list