[webkit-reviews] review granted: [Bug 231370] Do not check for firstLineStyle while constructing RenderText : [Attachment 440511] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 10:35:42 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 231370: Do not check for firstLineStyle while constructing RenderText
https://bugs.webkit.org/show_bug.cgi?id=231370

Attachment 440511: Patch

https://bugs.webkit.org/attachment.cgi?id=440511&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 440511
  --> https://bugs.webkit.org/attachment.cgi?id=440511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440511&action=review

> Source/WebCore/rendering/RenderText.cpp:1432
>      // FIXME: All these checks should be more fine-grained at the inline
item level.

I guess this FIXME is still relevant?


More information about the webkit-reviews mailing list