[webkit-reviews] review granted: [Bug 231285] Add support for processing push events without service worker clients : [Attachment 440372] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 231285: Add support for processing push events without service worker
clients
https://bugs.webkit.org/show_bug.cgi?id=231285

Attachment 440372: Patch

https://bugs.webkit.org/attachment.cgi?id=440372&action=review




--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 440372
  --> https://bugs.webkit.org/attachment.cgi?id=440372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440372&action=review

> Source/WebCore/workers/service/server/SWServer.cpp:1218
> +	       terminateWorkerTimer->startOneShot(weakThis &&
weakThis->m_isProcessTerminationDelayEnabled ? defaultTerminationDelay : 1_s);

Does this mean that we have one second to:
1. IPC the SW process
2. Dispatch to the SW thread
3. Dispatch and handle the push event in JS
4. Dispatch back to the main thread
5. IPC back to the network process

If so, doesn't it seem a bit low? Seems like this could cause flakiness on some
slower / overloaded machines.

I think our UIProcess responsiveness timer uses 3 seconds and even then, is
only enabled on release builds (No debug builds, no ASAN, not under debugger).