[webkit-reviews] review granted: [Bug 231347] Clean up state maintenance around animated scrolls : [Attachment 440466] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 7 01:18:00 PDT 2021

Martin Robinson <mrobinson at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 231347: Clean up state maintenance around animated scrolls

Attachment 440466: Patch


--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 440466
  --> https://bugs.webkit.org/attachment.cgi?id=440466

View in context: https://bugs.webkit.org/attachment.cgi?id=440466&action=review

Really glad to see this simplification.

> Source/WebCore/platform/ScrollView.cpp:530
> +    if ((!delegatesScrolling() || currentScrollType() == ScrollType::User)
&& scrollAnimationStatus() == ScrollAnimationStatus::NotAnimating &&
newScrollPosition == this->scrollPosition())

I wonder about the combination of testing `scrollAnimationStatus() ==
ScrollAnimationStatus::NotAnimating` and the call to
`scrollAnimator().cancelAnimations();` above. Perhaps `scrollAnimationStatus()
== ScrollAnimationStatus::NotAnimating` is always true?

More information about the webkit-reviews mailing list