[webkit-reviews] review denied: [Bug 231169] [Performance] Optimize RenderLayer::calculateRects : [Attachment 440356] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied cathiechen
<cathiechen at igalia.com>'s request for review:
Bug 231169: [Performance] Optimize RenderLayer::calculateRects
https://bugs.webkit.org/show_bug.cgi?id=231169

Attachment 440356: Patch

https://bugs.webkit.org/attachment.cgi?id=440356&action=review




--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 440356
  --> https://bugs.webkit.org/attachment.cgi?id=440356
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440356&action=review

> Source/WebCore/rendering/RenderLayer.cpp:4630
> +	   bool backgroundRectNotNeedRepaint = !hasBackgroundClipRect
> +	       && m_repaintRectsValid
> +	       &&
!m_repaintRects.clippedOverflowRect.intersects(backgroundRect.rect())
> +	       &&
!m_repaintRects.outlineBoundsRect.intersects(backgroundRect.rect());

This seems wrong. Clip rect computation should be independent of cached repaint
rects, and this code is not about needing repaint.