[webkit-reviews] review canceled: [Bug 231314] Cache PannerNode's azimuth, elevation and coneGain : [Attachment 440393] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 16:33:17 PDT 2021

Chris Dumez <cdumez at apple.com> has canceled Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 231314: Cache PannerNode's azimuth, elevation and coneGain

Attachment 440393: Patch


--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 440393
  --> https://bugs.webkit.org/attachment.cgi?id=440393

View in context: https://bugs.webkit.org/attachment.cgi?id=440393&action=review

>> Source/WebCore/Modules/webaudio/AudioListener.cpp:126
>> +void AudioListener::updateDirtyState()
> I must be missing something, but it seems like this function says "if nothing
has changed, then we are dirty", which is opposite how I usually understand the
phrase "dirty" in rendering. What am I missing?

Uh? I think I messed things up with a last minute patch clean up before
uploading. I agree this looks backwards now.

More information about the webkit-reviews mailing list