[webkit-reviews] review granted: [Bug 231327] Rewrite LayoutTests/plugins/object-onfocus-mutation-crash.html to stop relying on autofocus : [Attachment 440428] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 13:35:28 PDT 2021


Chris Dumez <cdumez at apple.com> has granted  review:
Bug 231327: Rewrite LayoutTests/plugins/object-onfocus-mutation-crash.html to
stop relying on autofocus
https://bugs.webkit.org/show_bug.cgi?id=231327

Attachment 440428: Patch

https://bugs.webkit.org/attachment.cgi?id=440428&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 440428
  --> https://bugs.webkit.org/attachment.cgi?id=440428
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440428&action=review

> LayoutTests/plugins/object-onfocus-mutation-crash.html:4
> +<object data="a">

Oh, I misread. You merely moved the <object>

> LayoutTests/plugins/object-onfocus-mutation-crash.html:22
> +    finish();

Any reason we can't keep calling finish asynchronously?


More information about the webkit-reviews mailing list