[webkit-reviews] review denied: [Bug 231267] Pull modifier key extraction into TestRunnerShared : [Attachment 440418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 6 13:22:50 PDT 2021

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 231267: Pull modifier key extraction into TestRunnerShared

Attachment 440418: Patch


--- Comment #9 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 440418
  --> https://bugs.webkit.org/attachment.cgi?id=440418

View in context: https://bugs.webkit.org/attachment.cgi?id=440418&action=review

> Tools/TestRunnerShared/cocoa/ModifierKeys.h:38
> +- (ModifierKeys*)modifierKeysWithKey:(NSString *)key
modifiers:(int)modifiers keyLocation:(unsigned)keyLocation;

This needs to be a class method :
+ (ModifierKeys*) ...

> Tools/TestRunnerShared/cocoa/ModifierKeys.mm:45
> +- (ModifierKeys*)modifierKeysWithKey:(NSString *)character
modifiers:(int)modifiers keyLocation:(unsigned)keyLocation

This should be an init method, then you need the class method that alloc/inits
the object then returns it.

> Tools/TestRunnerShared/cocoa/ModifierKeys.mm:240
> +    return self;

return [self autorelease];

More information about the webkit-reviews mailing list