[webkit-reviews] review granted: [Bug 231256] ASSERTION FAILED: This HTTPServer does not know how to respond to a request for /popup-after-redirection.html : [Attachment 440411] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 231256: ASSERTION FAILED: This HTTPServer does not know how to respond to a
request for /popup-after-redirection.html
https://bugs.webkit.org/show_bug.cgi?id=231256

Attachment 440411: Patch

https://bugs.webkit.org/attachment.cgi?id=440411&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 440411
  --> https://bugs.webkit.org/attachment.cgi?id=440411
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440411&action=review

> Tools/TestWebKitAPI/cocoa/HTTPServer.h:55
> +    void addResponse(String&& url, HTTPResponse&&);

This isn't a URL, it's a path.

> Tools/TestWebKitAPI/cocoa/HTTPServer.mm:177
> +    m_requestData->requestMap.add(WTFMove(url), WTFMove(response));

It might be worth asserting that we don't already have this path.  If someone
hits that assertion, it's probably a bug in their test.