[webkit-reviews] review granted: [Bug 231185] Add support for FileSystemSyncAccessHandle : [Attachment 440280] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 231185: Add support for FileSystemSyncAccessHandle
https://bugs.webkit.org/show_bug.cgi?id=231185

Attachment 440280: Patch

https://bugs.webkit.org/attachment.cgi?id=440280&action=review




--- Comment #16 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 440280
  --> https://bugs.webkit.org/attachment.cgi?id=440280
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440280&action=review

> Source/WebCore/Modules/filesystemaccess/FileSystemFileHandle.idl:34
> +    [EnabledBySetting=AccessHandleEnabled, Exposed=Worker]
Promise<FileSystemSyncAccessHandle> createSyncAccessHandle();

If we want to expose FileSystemFileHandle in service workers, we need to make
sure createSyncAccessHandle is not exposed.
Worth writing a test.

> LayoutTests/storage/filesystemaccess/resources/sync-access-handle-basics.js:5
> +description("This test checks basic funtionalities of
FileSystemSyncAccessHandle.");

Seems like they could be WPT tests that we could at some point upstream