[webkit-reviews] review granted: [Bug 230743] IPC SimpleArgumentEncoder should static_assert(std::is_trivially_copyable<T>) : [Attachment 440250] Patch

[bugzilla-daemon at webkit.org]

Kimmo Kinnunen <kkinnunen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 230743: IPC SimpleArgumentEncoder should
static_assert(std::is_trivially_copyable<T>)
https://bugs.webkit.org/show_bug.cgi?id=230743

Attachment 440250: Patch

https://bugs.webkit.org/attachment.cgi?id=440250&action=review




--- Comment #3 from Kimmo Kinnunen <kkinnunen at apple.com> ---
Comment on attachment 440250
  --> https://bugs.webkit.org/attachment.cgi?id=440250
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440250&action=review

> Source/WebKit/Platform/IPC/ArgumentCoders.h:47
>      template<typename Encoder>

I think you should be able to assert once in the class scope.

template<typename T> struct SimpleArgumentCoder {
    static_assert(std::is_trivially_copyable_v<T>);
    ....