[webkit-reviews] review denied: [Bug 231258] Prevent test functionality in AdAttributionDaemon when not running tests : [Attachment 440273] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 5 22:11:17 PDT 2021


Alexey Proskuryakov <ap at webkit.org> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 231258: Prevent test functionality in AdAttributionDaemon when not running
tests
https://bugs.webkit.org/show_bug.cgi?id=231258

Attachment 440273: Patch

https://bugs.webkit.org/attachment.cgi?id=440273&action=review




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 440273
  --> https://bugs.webkit.org/attachment.cgi?id=440273
Patch

I don't see a reason to land code that incompletely fixes the problem unless
there is a plan for how to fix it fully that depends on it.


More information about the webkit-reviews mailing list