[webkit-reviews] review granted: [Bug 231234] Allow text selection to flip. : [Attachment 440272] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 231234: Allow text selection to flip.
https://bugs.webkit.org/show_bug.cgi?id=231234

Attachment 440272: Patch

https://bugs.webkit.org/attachment.cgi?id=440272&action=review




--- Comment #6 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 440272
  --> https://bugs.webkit.org/attachment.cgi?id=440272
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440272&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1508
> +static std::pair<std::optional<SimpleRange>, WebKit::SelectionWasFlipped>
rangeForPointInRootViewCoordinates(Frame& frame, const IntPoint&
pointInRootViewCoordinates, bool baseIsStart, bool selectionFlippingEnabled)

Nit - you can omit the `WebKit::` here.