[webkit-reviews] review granted: [Bug 231252] Speculative fix for a null pointer dereference in ByteCodeParser::handlePutByVal. : [Attachment 440265] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 231252: Speculative fix for a null pointer dereference in
ByteCodeParser::handlePutByVal.
https://bugs.webkit.org/show_bug.cgi?id=231252

Attachment 440265: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=440265&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 440265
  --> https://bugs.webkit.org/attachment.cgi?id=440265
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=440265&action=review

r=me

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:8881
> +		   auto* impl = string->tryGetValueImpl();
> +		   ASSERT(impl); // FIXME: rdar://83902782
> +		   if (impl && impl->isAtom() &&
!parseIndex(*const_cast<StringImpl*>(impl))) {

Similar thing exists on op_put_private_name. Please change all of these things
in DFG::ByteCodeParser.