[webkit-reviews] review granted: [Bug 231248] Add an entitlement check to only allow AdAttributionDaemon to be connected to by the network process : [Attachment 440257] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 231248: Add an entitlement check to only allow AdAttributionDaemon to be
connected to by the network process
https://bugs.webkit.org/show_bug.cgi?id=231248

Attachment 440257: Patch

https://bugs.webkit.org/attachment.cgi?id=440257&action=review




--- Comment #2 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 440257
  --> https://bugs.webkit.org/attachment.cgi?id=440257
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440257&action=review

>
Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm:84
> +	       NSLog(@"connection attempted connection without required
entitlement");

Does this look right in the log starting with lower case?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/EventAttribution.mm:513
> +    xpc_connection_set_event_handler(connection.get(), ^(xpc_object_t event)
{
> +	   if (event == XPC_ERROR_CONNECTION_INTERRUPTED) {
> +	       done = true;
> +    });

Not sure if this tests enough. Isn't the purpose to verify that the connection
is never established? This just verifies that it's dropped, perhaps only
eventually.

Also, failing as timeout isn't always understood to be a legitimate failure in
practice.