[webkit-reviews] review granted: [Bug 178835] Web Inspector: Styles: format style declarations after editing : [Attachment 434469] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 178835: Web Inspector: Styles: format style declarations after editing
https://bugs.webkit.org/show_bug.cgi?id=178835

Attachment 434469: Patch

https://bugs.webkit.org/attachment.cgi?id=434469&action=review




--- Comment #18 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 434469
  --> https://bugs.webkit.org/attachment.cgi?id=434469
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434469&action=review

r=me

I still think it's a bit odd to have formatted text suddenly appear in the
middle of a minified resource, but perhaps that could be a good thing as it
would stand out more (and make subsequent edits easier).  It's also fair to say
that when viewing a minified resource Web Inspector should auto-format it
anyways, so unless the developer manually changes back to the minified view or
saves the file to disk they're unlikely to be bothered by this.  Most
developers spend their time in the Styles details sidebar panel in the Elements
Tab anyways.

> Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:499
> +	   if (options.includeGroupingsAndSelectors) {

NIT: I'm just realizing now that this probably should be
`includeSelectorsAndGroupings` since you can't have a grouping without
selectors but you can have the opposite, but it's not a big deal :P