[webkit-reviews] review granted: [Bug 231060] Implement missing functions in PrivateClickMeasurementDaemonClient : [Attachment 440159] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 231060: Implement missing functions in PrivateClickMeasurementDaemonClient
https://bugs.webkit.org/show_bug.cgi?id=231060

Attachment 440159: Patch

https://bugs.webkit.org/attachment.cgi?id=440159&action=review




--- Comment #7 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 440159
  --> https://bugs.webkit.org/attachment.cgi?id=440159
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440159&action=review

>
Source/WebKit/NetworkProcess/PrivateClickMeasurement/PrivateClickMeasurementCon
nection.h:63
> +    explicit ConnectionToMachService(CString&& machServiceName,
NetworkSession&);

Probably don’t need the explicit.

>
Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonConnectionSet.mm
:47
> +    m_connections.set(connection, DebugModeEnabled::No);

add() is more efficient and should suffice given that you don’t expect the key
to exist.