[webkit-reviews] review denied: [Bug 231179] Fix wrong edge type from get-by-val in 32 bits : [Attachment 440079] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 231179: Fix wrong edge type from get-by-val in 32 bits
https://bugs.webkit.org/show_bug.cgi?id=231179

Attachment 440079: Patch

https://bugs.webkit.org/attachment.cgi?id=440079&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 440079
  --> https://bugs.webkit.org/attachment.cgi?id=440079
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440079&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:4518
> +	   JSValueOperand baseOperand(this, baseEdge);
> +	   generate(baseOperand.gpr());

base is JSValue, but it only passes payload part of JSValue. In 32bit, there is
tag part, which needs to be passed. If it is a JSValue, then we need to use
JSValueRegs.