[webkit-reviews] review denied: [Bug 181916] [GTK] Reenable -fvisibility=hidden : [Attachment 440201] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 5 10:03:47 PDT 2021
Don Olmstead <don.olmstead at sony.com> has denied review:
Bug 181916: [GTK] Reenable -fvisibility=hidden
https://bugs.webkit.org/show_bug.cgi?id=181916
Attachment 440201: Patch
https://bugs.webkit.org/attachment.cgi?id=440201&action=review
--- Comment #71 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 440201
--> https://bugs.webkit.org/attachment.cgi?id=440201
Patch
OBJECT libraries is the CMake way of doing --whole-archive. The _FRAMEWORKS
macro relies on OBJECT libraries to properly set the libraries.
Why isn't OBJECT being used here?
More information about the webkit-reviews
mailing list