[webkit-reviews] review canceled: [Bug 181916] [GTK] Reenable -fvisibility=hidden : [Attachment 440201] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 5 09:50:06 PDT 2021

Michael Catanzaro <mcatanzaro at gnome.org> has canceled  review:
Bug 181916: [GTK] Reenable -fvisibility=hidden

Attachment 440201: Patch


--- Comment #70 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 440201
  --> https://bugs.webkit.org/attachment.cgi?id=440201

Actually I'm removing my r+ because I think this might break the
check-for-invalid-symbols-in-version-script safety check that you added in bug
#179914. If -fvisibility=hidden is used, then symbols that don't use BEXPORT or
WTF_EXPORT_PRIVATE could wind up duplicated, right? That would reintroduce bug

More information about the webkit-reviews mailing list