[webkit-reviews] review granted: [Bug 230953] [GTK][WPE] REGRESSION: Async scrolling jumps to the top of the page until keyboard-initiated paging : [Attachment 440186] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Chris Lord
<clord at igalia.com>'s request for review:
Bug 230953: [GTK][WPE] REGRESSION: Async scrolling jumps to the top of the page
until keyboard-initiated paging
https://bugs.webkit.org/show_bug.cgi?id=230953

Attachment 440186: Patch

https://bugs.webkit.org/attachment.cgi?id=440186&action=review




--- Comment #11 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 440186
  --> https://bugs.webkit.org/attachment.cgi?id=440186
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440186&action=review

This is a very nice refactor.

> Source/WebCore/platform/ScrollingEffectsController.cpp:231
> +	   m_currentAnimation->stop();

What I understand here is that it's not a big deal to not clear the animation
here. Since it is cleared below though, clear it here or don't clear it below
for the sake of consistency.